Marble Code Provenance Review - Revision history

Arnulf at 10:26, 22 October 2013

2013-10-22T10:26:06Z

Arnulf: /* /marble/sources/src/lib/kineticmodel.cpp (CHECK) */

2013-09-09T07:58:26Z

/marble/sources/src/lib/kineticmodel.cpp (CHECK)

Arnulf: /* Review Document */

2013-09-09T07:52:28Z

Review Document

Arnulf: /* FAQ */

2013-09-09T07:52:01Z

FAQ

Arnulf: /* /marble/sources/src/plugins/render/twitter (CHECK) */ -> resolved

2013-09-09T07:48:25Z

/marble/sources/src/plugins/render/twitter (CHECK): -> resolved

Arnulf: /* /marble/sources/src/plugins/render/foursquare (CHECK) */ -> issues resolved, clean

2013-09-09T07:47:45Z

/marble/sources/src/plugins/render/foursquare (CHECK): -> issues resolved, clean

Arnulf: /* Checked Code */

2013-09-09T07:46:52Z

Checked Code

Arnulf: /* /marble/sources/src/plugins/render/panoramio (CHECK) */

2013-07-17T12:47:17Z

/marble/sources/src/plugins/render/panoramio (CHECK)

Arnulf: /* /marble/sources/src/plugins/render/satellites/sg4p (CHECK) */

2013-07-17T12:46:32Z

/marble/sources/src/plugins/render/satellites/sg4p (CHECK)

Arnulf: /* /marble/sources/src/plugins/render/twitter (CHECK) */

2013-07-12T09:43:29Z

/marble/sources/src/plugins/render/twitter (CHECK)

← Older revision		Revision as of 10:26, 22 October 2013
Line 1:		Line 1:
		+	'''''[[Marble]] has succesfully [http://wiki.osgeo.org/wiki/Press_Release_Marble_Virtual_Globe_Graduates_Incubation graduated form Incubation] and is now an official OSGeo project. '''''
		+
		+
	= Goal =		= Goal =
	To establish a reasonable comfort level that the Marble Project does not have improperly contributed code, and that the code is all under the project license.		To establish a reasonable comfort level that the Marble Project does not have improperly contributed code, and that the code is all under the project license.

@@ Line 12: / Line 12: @@
 # Prepare a list of external dependencies with with potentially problematic license terms.  So, all non-free libraries for instance.  All libraries with licenses that might conflict (for instance GDAL's use of GPL'ed GRASS libraries in the non-GPL GDAL).
-=== /marble/sources/src/lib/kineticmodel.cpp (CHECK) ===
+=== /marble/sources/src/lib/kineticmodel.cpp (clean) ===
-Somewhat different license but should be in order.
+Different license and copyright but compatible.
 <pre>
 /*

← Older revision		Revision as of 07:52, 9 September 2013
Line 300:		Line 300:
	# Maintain a list of all copyright holders identified in the review document. This list is essentially everyone who would need to agree to relicense the project. It may be desirable to seek copyright assignment to a "project lead", or to the foundation to reduce the number of copyright holders for the project though this is not required.		# Maintain a list of all copyright holders identified in the review document. This list is essentially everyone who would need to agree to relicense the project. It may be desirable to seek copyright assignment to a "project lead", or to the foundation to reduce the number of copyright holders for the project though this is not required.

−	~~= Review Document =~~
−
−	The result of the provenance review is two fold. First, there is clarification and "fixes" done during the review. For instance, adding missing copyright notices, or factoring out external libraries. The second is a review report with a fairly detailed list of outstanding issues, ambiguities and information of note.
−
−	The review document will be distributed to the project PSC members, as well as the incubation committee. Based on it, the incubation committee may require the project to do additional work, either resolving ambiguities, factoring items out, or rewriting questional components.
−
−	When completed, a much briefer form of the review document should be prepared, just listing information that would be pertinent to folks using the project. Essentially a summary. This summary might live in source control as README.LICENSE or something similar.
−
−	~~See also [[Code_Provenance_Review#FAQ \| Code Provenance Review FAQ]].~~

	[[Category:Incubation]]		[[Category:Incubation]]

@@ Line 308: / Line 308: @@
 When completed, a much briefer form of the review document should be prepared, just listing information that would be pertinent to folks using the project.  Essentially a summary.  This summary might live in source control as README.LICENSE or something similar.
-= FAQ =
+See also [[Code_Provenance_Review#FAQ | Code Provenance Review FAQ]].
 [[Category:Incubation]]

@@ Line 280: / Line 280: @@
 This directory is clean.
-=== /marble/sources/src/plugins/render/twitter (CHECK) ===
+=== /marble/sources/src/plugins/render/twitter (clean) ===
 === /marble/sources/src/plugins/render/weather (CHECK) ===

@@ Line 157: / Line 157: @@
 This directory is clean.
-=== /marble/sources/src/plugins/render/foursquare (CHECK) ===
+=== /marble/sources/src/plugins/render/foursquare (clean) ===
 === /marble/sources/src/plugins/render/gpsinfo (clean) ===

@@ Line 86: / Line 86: @@
 == Checked Code ==
-The following lists all checked files and whether there are issues.
+The following list containes all files that were checked manually by the mentor. All issues have been addressed by the project immediately (within max 10 days).
 === /marble/sources/src/bindings/python (clean) ===
 ''See the file marble/docs/bindings/python/Python_bindings_for_marble_library.txt.'' All files have correct headers.
-=== /marble/sources/src/lib (CHECK) ===
+=== /marble/sources/src/lib (clean) ===
-This directory is clean except if otherwise referenced below. One exception (kineticmodel.cpp) has been copied into the libraries section above.
+This directory is clean except if otherwise referenced below.
 * LatLonBoxWidget.cpp contains no copyright / author, instead this:

@@ Line 192: / Line 192: @@
 This directory is clean.
-=== /marble/sources/src/plugins/render/panoramio (CHECK) ===
+=== /marble/sources/src/plugins/render/panoramio (clean) ===
 Missing license header:
 * Panoramio.py
 === /marble/sources/src/plugins/render/photo (clean) ===

@@ Line 214: / Line 214: @@
 This directory is clean.
-=== /marble/sources/src/plugins/render/satellites/sg4p (CHECK) ===
+=== /marble/sources/src/plugins/render/satellites/sg4p (clean) ===
-No license header. Instead this (example from sgp4unit.h):
+Some files come from the public domain and therefore have no license header. Example from sgp4unit.h:
 <pre>

@@ Line 279: / Line 279: @@
 === /marble/sources/src/plugins/render/twitter (CHECK) ===
-There is a Google API key refernced, not sure what this might mean for copyrights?
+There is a Google API key referenced, not sure what this might mean for copyrights?
 * twitterPlugin.cpp