GRASS Provenance Review - Revision history

Neteler: /* gui */

2008-03-29T20:18:05Z

gui

Neteler: /* Code provenance review procedure */

2008-01-25T13:36:00Z

Code provenance review procedure

Neteler: + Code provenance review procedure

2008-01-25T10:20:38Z

+ Code provenance review procedure

Arnulf: /* TODO */ all to dos have been done, section removed

2008-01-23T20:22:38Z

TODO: all to dos have been done, section removed

Arnulf: /* TODO */ main.c files have been updated

2008-01-23T20:22:03Z

TODO: main.c files have been updated

Neteler: contributors with/out write access, translators

2007-11-02T14:58:45Z

contributors with/out write access, translators

Neteler: Source code browsing sites

2007-05-31T19:34:40Z

Source code browsing sites

Arnulf: /* Mentor Notes */ moved to GRASS Incubation Progress

2007-04-26T17:34:58Z

Mentor Notes: moved to GRASS Incubation Progress

Arnulf: /* Mentor Notes */

2007-04-20T13:14:08Z

Mentor Notes

Arnulf: /* Mentor Notes */

2007-04-20T13:13:23Z

Mentor Notes

← Older revision		Revision as of 20:18, 29 March 2008
Line 93:		Line 93:

	d.m and gis.m commands		d.m and gis.m commands
		+	* d.m is based on tcltkgrass which was contributed to the public domain ([http://lists.osgeo.org/pipermail/grass-user/1994-July/021521.html announcement])
		+	* gis.m is based on d.m

	=== imagery ===		=== imagery ===

@@ Line 56: / Line 56: @@
 ** local Changelog file
-Then the reviewer browsed main.c for offensive code (essentially incompliant copyright notices and such), added missing authors to the copyright header from description.html and polished the layout of the copyright header. Then submission to CVS (now OSGeo SVN).
+Then the reviewer browsed main.c for offensive code (essentially incompliant copyright notices and such), added missing authors to the copyright header from description.html and polished the layout of the copyright header. Then submission to CVS (now [http://trac.osgeo.org/grass/ OSGeo GRASS SVN]).
 Kudos to Schuyler Erle for writing the PERL script which quite helped (tools/copywrite.pl). The expansion of CVS names was done by reading in contributors.csv. M Neteler feel that this is a valid level of automatisation.

← Older revision		Revision as of 10:20, 25 January 2008
Line 44:		Line 44:

	== Code Reviewed ==		== Code Reviewed ==
		+
		+	=== Code provenance review procedure ===
		+
		+	It was a manual, interactive procedure with some scripted help. The automated part included:
		+	* search of main.c files without copyright statement (those with GPL statement have been vetted already 1-2 times earlier, see grass-dev archive)
		+	* extraction of ChangeLog for the actual main.c file from CVS
		+	* extraction of authors from Changelog file and draft insertion into actual main.c
		+	* open of text editor with following files:
		+	** main.c in process
		+	** related description.html (which contains authors at page bottom; in order to check for unmentioned authors from the pre-CVS times)
		+	** local Changelog file
		+
		+	Then the reviewer browsed main.c for offensive code (essentially incompliant copyright notices and such), added missing authors to the copyright header from description.html and polished the layout of the copyright header. Then submission to CVS (now OSGeo SVN).
		+
		+	Kudos to Schuyler Erle for writing the PERL script which quite helped (tools/copywrite.pl). The expansion of CVS names was done by reading in contributors.csv. M Neteler feel that this is a valid level of automatisation.
		+
		+	'''Reminder:''' the GRASS Development Team has already done rigorous code vetting when GRASS was made GPL'ed software (1999).
		+
		+	'''Note 1:''' All contributors with SVN access have agreed to RFC2: http://download.osgeo.org/grass/grass6_progman/rfc/rfc2_psc.html (RFC 2: Legal aspects of code contributions)
		+
		+	'''Note 2:''' All added copyright statements are documented in ChangeLog (now also in trac): http://grass.osgeo.org/grass63/source/snapshot/ChangeLog.gz

	=== db ===		=== db ===

← Older revision		Revision as of 20:22, 23 January 2008
Line 210:		Line 210:
	nviz and xganim commands		nviz and xganim commands

−	~~=== TODO ===~~
−
−	* copyright statement is included in all main.c files
−	~~done --[[User:Seven\|Seven]] 15:22, 23 January 2008 (EST)~~

	[[Category:Incubation]]		[[Category:Incubation]]

@@ Line 212: / Line 212: @@
 === TODO ===
-* add copyright statement to remaining main.c files (90 files as of 4/2007)
+* copyright statement is included in all main.c files
 [[Category:Incubation]]

@@ Line 3: / Line 3: @@
 == Committers ==
-Current:
+'''Current:'''
-See AUTHORS file and ChangeLog
+See AUTHORS file and ChangeLog, additionally:
+* [http://freegis.org/cgi-bin/viewcvs.cgi/~checkout~/grass6/contributors.csv contributors with write access]
-List of [http://grass.itc.it/devel/grassreleases.html GRASS Versions] (1984-today)
+* [http://freegis.org/cgi-bin/viewcvs.cgi/~checkout~/grass6/contributors_extra.csv contributors without write access]
 Historical and Current contributors (incomplete):
@@ Line 14: / Line 15: @@
 * [http://freegis.org/cgi-bin/viewcvs.cgi/~checkout~/grass/AUTHORS GRASS 5 Core Team]
 * [http://freegis.org/cgi-bin/viewcvs.cgi/~checkout~/grass6/AUTHORS GRASS 6 Core Team] , see also [http://www.grass.itc.it/grass61/source/snapshot/ChangeLog.gz ChangeLog file]
 * [http://web.soccerlab.polymtl.ca/grass-evolution/cvs-stat/overall/index.html CVS statistics for GRASS 6]
 * [http://www.ohloh.net/projects/3666 Ohloh GRASS CVS statistics]
 == Issues and vetting process ==

@@ Line 27: / Line 27: @@
 * Ongoing: Missing copyright statement addition are continuously added
 ** To simplify to trace down code contributors, there is a PERL script (tools/copywrite.pl) in the source code which automatically searches all main.c files which are lacking a Copyright statement. It also automatically extracts the known contributors from the local ChangeLog file (which is created on the fly from CVS) and generates a standard header within such main.c file. Manual review is obviously still needed before submitting the updated file to CVS.
 == Included Libraries ==

← Older revision		Revision as of 17:34, 26 April 2007
Line 210:		Line 210:

	[[Category:Incubation]]		[[Category:Incubation]]
−
−	~~=== Mentor Notes ===~~
−	~~Putting together notes for a documentatoin of the vetting process.~~
−	* Example of header addition: http://grass.itc.it/pipermail/grass-commit/2007-April/028266.html
−	* more of them here: http://grass.itc.it/pipermail/grass-commit.mbox/grass-commit.mbox

@@ Line 212: / Line 212: @@
 === Mentor Notes ===
-PUtting together notes for a documentatoin of the vetting process.
+Putting together notes for a documentatoin of the vetting process.
 * Example of header addition: http://grass.itc.it/pipermail/grass-commit/2007-April/028266.html
 * more of them here: http://grass.itc.it/pipermail/grass-commit.mbox/grass-commit.mbox