AJAX WebMapping Vector Rendering Design - Revision history

Wiki-Camerons: /* Summary */

2006-11-10T04:48:49Z

Summary

Wiki-Anselm: /* Introduction */

2006-11-09T16:24:22Z

Introduction

Wiki-Stvn: /* EventManager / GeometryControl */

2006-11-09T09:57:44Z

EventManager / GeometryControl

Wiki-Bertil: /* EventManager / GeometryControl */

2006-11-09T07:43:42Z

EventManager / GeometryControl

Wiki-Camerons: /* Renderer / Graphics / Sheet */

2006-11-09T04:38:54Z

Renderer / Graphics / Sheet

Wiki-Camerons: /* Feature and Geometry */

2006-11-09T04:23:55Z

Feature and Geometry

Wiki-Camerons: /* Feature and Geometry */

2006-11-09T04:02:34Z

Feature and Geometry

Wiki-Camerons: /* Renderer / Graphics */

2006-11-09T04:01:25Z

Renderer / Graphics

Wiki-Camerons: /* Layer/Vector */

2006-11-09T03:22:56Z

Layer/Vector

Wiki-Camerons: /* Introduction */

2006-11-09T02:47:53Z

Introduction

← Older revision		Revision as of 04:48, 10 November 2006
Line 130:		Line 130:

	More detailed comments follow.		More detailed comments follow.
		+
		+	== General ==
		+
		+	Bertil's code seems to depend upon prototype.js. As I understand it Openlayers have tried to remove the dependance upon prototype so this should be fixed.

	== Feature and Geometry ==		== Feature and Geometry ==

@@ Line 114: / Line 114: @@
 This is a code review of the 2 vector rendering code bases at:
-# Paul and Anselm's code at: https://svn.openlayers.org/sandbox/pagameba/vector/lib Design at: http://wiki.osgeo.org/index.php/AJAX_WebMapping_Vector_Rendering_Design
+# Paul and Anselm's code at: http://svn.openlayers.org/sandbox/pagameba/vector/lib Design at: http://wiki.osgeo.org/index.php/AJAX_WebMapping_Vector_Rendering_Design
-# Bertil and Pierre's code at https://svn.openlayers.org/sandbox/bertil/lib Design below:
+# Bertil and Pierre's code at http://svn.openlayers.org/sandbox/bertil/lib Design below:
 http://dev.camptocamp.com/openlayers/graphics/Edition.png

← Older revision		Revision as of 09:57, 9 November 2006
Line 175:		Line 175:
	* Bertil's code allows an eventManager to be assigned in the Renderer. I don't understand how this works. Mouse events seem to be passed back to the Map object? Do these events include the id of the feature which triggered the event? How are controls associated with the events?		* Bertil's code allows an eventManager to be assigned in the Renderer. I don't understand how this works. Mouse events seem to be passed back to the Map object? Do these events include the id of the feature which triggered the event? How are controls associated with the events?
	* Bertil: - The eventManager property of Renderer is a reference to the map event manager. This reference allow the renderer to trigg custum edition events when you click, doubleClick (, etc) on represented shapes. These events contains geometry model reference, so when you catch an event you catch also the concerned geometry. The final goal is to abstractify edition events to manage SVG/VML DOM Events and simulate them in Canvas. In this architecture, edition controls are catching the edition events to edit the geometry features. (sorry for english mistakes, it's not my mother tongue)		* Bertil: - The eventManager property of Renderer is a reference to the map event manager. This reference allow the renderer to trigg custum edition events when you click, doubleClick (, etc) on represented shapes. These events contains geometry model reference, so when you catch an event you catch also the concerned geometry. The final goal is to abstractify edition events to manage SVG/VML DOM Events and simulate them in Canvas. In this architecture, edition controls are catching the edition events to edit the geometry features. (sorry for english mistakes, it's not my mother tongue)
		+	* Steven: - I discovered that there's a problem with events on shapes: if you use mouseover events on, for instance, points you quickly get a mouse out event when you drag the thing. Points are so small that it's difficult to keep the point under the mouse all the time. I solved it by increasing the point size during mouseOver/mouseMove events.

← Older revision		Revision as of 07:43, 9 November 2006
Line 174:		Line 174:
	* Paul doesn't have a GeometryControl object yet (as per my UML design).		* Paul doesn't have a GeometryControl object yet (as per my UML design).
	* Bertil's code allows an eventManager to be assigned in the Renderer. I don't understand how this works. Mouse events seem to be passed back to the Map object? Do these events include the id of the feature which triggered the event? How are controls associated with the events?		* Bertil's code allows an eventManager to be assigned in the Renderer. I don't understand how this works. Mouse events seem to be passed back to the Map object? Do these events include the id of the feature which triggered the event? How are controls associated with the events?
		+	* Bertil: - The eventManager property of Renderer is a reference to the map event manager. This reference allow the renderer to trigg custum edition events when you click, doubleClick (, etc) on represented shapes. These events contains geometry model reference, so when you catch an event you catch also the concerned geometry. The final goal is to abstractify edition events to manage SVG/VML DOM Events and simulate them in Canvas. In this architecture, edition controls are catching the edition events to edit the geometry features. (sorry for english mistakes, it's not my mother tongue)

@@ Line 164: / Line 164: @@
 ** Sheet.js has children Sheet/Svg.js Sheet/Vml.js etc.
 ** SheetFactory is a simple class which returns the correct instaniation of Sheet.
 == Style ==
 * Bertil has a Style object, but it doesn't seem to be used yet.

← Older revision		Revision as of 04:23, 9 November 2006
Line 121:		Line 121:

	The intent of this review is to make suggestions on how the 2 code bases can be merged into one.		The intent of this review is to make suggestions on how the 2 code bases can be merged into one.
		+
		+	== Summary ==
		+	Paul has a good programming style. I like his commenting, use of inheritence, and completeness when it comes filling in all the initialisation/destroy/etc type functions. I'd like to see this in the final code base. At the moment, Paul has working code (old design) and half complete code (new design).
		+
		+	Bertil has working code and a solid design.
		+
		+	What I suggest is that we start from Bertil's code base, and apply patches from Paul's code and a couple of changes to the design.
		+
		+	More detailed comments follow.

	== Feature and Geometry ==		== Feature and Geometry ==

@@ Line 126: / Line 126: @@
 The concept of Geometry is common between the two designs.
-Bertil has coded this at OpenLayers/Feature/Geometry/* , Paul hasn't.
+Bertil has coded this at OpenLayers/Feature/Geometry/* , I can't find something similar in Paul's code.
 So I propose we use Bertils code for this.

@@ Line 141: / Line 141: @@
 * Features are added one feature at a time instead of as an array. I suspect this would have better performance?
-== Renderer / Graphics ==
+== Renderer / Graphics / Sheet ==
 == EventManager / GeometryControl ==
 * Paul doesn't have a GeometryControl object yet (as per my UML design).
 * Bertil's code allows an eventManager to be assigned in the Renderer. I don't understand how this works. Mouse events seem to be passed back to the Map object? Do these events include the id of the feature which triggered the event? How are controls associated with the events?

← Older revision		Revision as of 03:22, 9 November 2006
Line 140:		Line 140:
	* A "freeze" concept which prevents painting until unfrozen		* A "freeze" concept which prevents painting until unfrozen
	* Features are added one feature at a time instead of as an array. I suspect this would have better performance?		* Features are added one feature at a time instead of as an array. I suspect this would have better performance?
		+
		+	== Renderer / Graphics ==
		+
		+	== EventManager / GeometryControl ==
		+	* Paul doesn't have a GeometryControl object yet (as per my UML design).
		+	* Bertil's code allows an eventManager to be assigned in the Renderer. I don't understand how this works. Mouse events seem to be passed back to the Map object? Do these events include the id of the feature which triggered the event? How are controls associated with the events?